Skip to content

feat(devcontainers-cli): add devcontainers-cli module #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 16, 2025
Merged

Conversation

defelmnq
Copy link
Contributor

Related to this issue

Create a new module to install @devcontainers/cli using npm.

@defelmnq defelmnq self-assigned this Apr 10, 2025
@defelmnq defelmnq added the coder_script Needs `coder_script` label Apr 10, 2025
@defelmnq defelmnq requested review from mafredri and matifali April 10, 2025 15:58
@defelmnq defelmnq requested a review from mtojek April 11, 2025 13:00
```tf
module "devcontainers-cli" {
source = "registry.coder.com/modules/devcontainers-cli/coder"
version = "release/claude-code/1.0.32"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does release/claude-code/1.0.32 exist or is it an example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is enforced by the update-version.sh script - not sure if @matifali has more info here on why.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be release/devcontainers-cli/1.0.0.

@mafredri
Copy link
Member

It might be nice to add Docker detection here as well and print a WARNING if docker command isn't found.

@defelmnq defelmnq requested review from mtojek and mafredri April 14, 2025 17:41
@defelmnq
Copy link
Contributor Author

Thanks @mafredri and @mtojek for the review - I added :

  • Detection of Docker
  • Support for pnpm and yarn
  • Fixes some return code and log lines

A question asked by Marcin about Does release/claude-code/1.0.32 exist or is it an example?
-> This one is enforced by the CI , maybe @matifali has more knowledge of why.

About naming, I'm up to keep devcontainers/cli as its explicit and map to the package.

Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions but otherwise looking good, thanks for implementing support for multiple package managers! 🎉

```tf
module "devcontainers-cli" {
source = "registry.coder.com/modules/devcontainers-cli/coder"
version = "release/claude-code/1.0.32"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be release/devcontainers-cli/1.0.0.

@defelmnq defelmnq requested a review from mafredri April 14, 2025 20:41
@matifali matifali removed the coder_script Needs `coder_script` label Apr 14, 2025
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor optional adjustments to improve the output, but nothing blocking on my side. Nice work!

defelmnq and others added 2 commits April 15, 2025 13:27
Co-authored-by: Mathias Fredriksson <[email protected]>
Co-authored-by: Mathias Fredriksson <[email protected]>
@defelmnq
Copy link
Contributor Author

PR Is ready, currently waiting for #426 to have easier versioning.

Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the correct version. With rebased after #431, We should be able to push a tag release/devcontainers-cli/v1.0.0. This is an ad-hoc arrangement until #426 is finalized.

@defelmnq
Copy link
Contributor Author

All good for me with @matifali last changes ✅ Thanks.

@defelmnq defelmnq merged commit d4b4ebd into main Apr 16, 2025
4 checks passed
@defelmnq defelmnq deleted the vvi-16432 branch April 16, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants