Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: add support for separate module versioning to CI #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add support for separate module versioning to CI #426
Changes from 29 commits
7f130f2
b0069e2
0611ef2
2269e58
c6cffc8
9bc5419
9b89ef4
038ef33
0b7a602
7d481e8
d5ecb98
7c95af8
324a383
96657d7
1a1dd69
4dbe948
bd1703b
6f2fe83
2998721
d63b332
a6984fb
0c4f954
fb3ae6f
6d925ca
bdd8dba
3f0615b
8200f2d
70e5da7
e4e5c73
57fc91f
68f5396
8aa9154
974f3f6
2086134
6b1b617
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One issue with this approach is that the tag will not include the updated README, it'll be updated after tagging meaning when you
git checkout release/module-name/v1.2.3
the README will statev1.2.2
.It's perhaps a minor thing, but makes me question the release method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice observation. Do you have any suggestions on a better approach?
We would have to reverse the behavior where the user chooses a tag, commits that to README, and then pushes a tag that matches that.
That will have more responsibility on the maintainer and can resurface #229.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not enough
-
's