🤖 feat: add vim editor support and editors.js configuration #1051
+1,042
−317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
ammar-agent
force-pushed
the
add-vim-editor-support
branch
from
0ac221a to
0e3c2fa
Compare
ammar-agent
force-pushed
the
add-vim-editor-support
branch
from
e5f03f6 to
d787b06
Compare
- Add ~/.mux/editors.js configuration file for editor definitions - Support two editor types: 'native' (GUI) and 'web_term' (terminal) - Ship with VS Code, Cursor, Zed, and Vim/Neovim as built-in editors - Add initialCommand support to terminal windows for vim integration - Refactor EditorService to load user-customizable JavaScript config - Add listEditors/setDefaultEditor IPC endpoints - Update Settings UI to fetch editor list from backend - Add comprehensive documentation at /docs/editor - Remove old localStorage-based editor configuration The editors.js file allows users to define custom editors with full control over how they open workspaces, supporting different behaviors for SSH vs local workspaces, browser vs desktop mode, etc. _Generated with mux_
- Add shadcn dropdown-menu component - Replace single edit button with dropdown showing all available editors - Default editor is marked with a checkmark - User can select any editor for one-off use - Update useOpenInEditor to accept optional editorId parameter
ammar-agent
force-pushed
the
add-vim-editor-support
branch
from
d787b06 to
aeb1c73
Compare
ThomasK33
reviewed
Dec 11, 2025
Comment on lines
+33
to
+51
| export type EditorOpenResult = | ||
| | { | ||
| /** Spawn a native/detached GUI process */ | ||
| type: "native"; | ||
| /** Command to execute */ | ||
| command: string; | ||
| /** Arguments to pass */ | ||
| args: string[]; | ||
| } | ||
| | { | ||
| /** Open in web terminal with this command */ | ||
| type: "web_term"; | ||
| /** Full command string to run in terminal */ | ||
| command: string; | ||
| } | ||
| | { | ||
| /** Editor cannot handle this context */ | ||
| error: string; | ||
| }; |
Member
There was a problem hiding this comment.
Does it make sense to turn those into Zod schemas and validate on load?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds first-class vim/neovim support and a JavaScript-based editor configuration system.
Changes
~/.mux/editors.jsinstead of localStorageinitialCommandsupport to terminal windowsGenerated with mux