account-verifier response type and values

[MatousJobanek]

let's move it to API to ensure that we use the same values at both places

https://redhat-internal.slack.com/archives/C061H0CGYBZ/p1782218221030119

Summary by CodeRabbit

• New Features
  • Added comprehensive account verification support with multiple verdict types (approved, rejected, phone verification required) and structured response handling for detailed feedback.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 27c70d00-1a5c-4a74-ab5c-007dfe6a4f64

📥 Commits

Reviewing files that changed from the base of the PR and between 920c974 and 53ec4fa.

📒 Files selected for processing (1)

• api/v1alpha1/usersignup_types.go

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• codeready-toolchain/api (manual)
• codeready-toolchain/toolchain-common (manual)
• codeready-toolchain/host-operator (manual)
• codeready-toolchain/toolchain-e2e (manual)

📜 Recent review details

⏰ Context from checks skipped due to timeout. (1)

• GitHub Check: Verify Dependencies

🧰 Additional context used

📓 Path-based instructions (1)

**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

• api/v1alpha1/usersignup_types.go

🔇 Additional comments (1)

api/v1alpha1/usersignup_types.go (1)

186-194: LGTM!

Also applies to: 196-207

---

Walkthrough

Adds AccountVerifierResult string type and three verdict constants (rejected, phone_verification, approved) to api/v1alpha1/usersignup_types.go. Introduces two new exported structs, AccountVerifierResponse and AccountVerifierReason, with JSON-tagged fields to represent structured account verifier responses.

Changes

Account Verifier Response Types

Layer / File(s)	Summary
AccountVerifier verdict constants and response structs api/v1alpha1/usersignup_types.go	Defines AccountVerifierResult string type with rejected, phone_verification, and approved constants. Adds AccountVerifierResponse struct (result, reasons, error JSON fields) and AccountVerifierReason struct (check, detail JSON fields).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

feature

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is largely incomplete, missing most required sections from the template including goals summary and all required checks (make generate, other project impacts, CRD changes, and related PR links).	Complete the description by adding: a detailed summary of goals, answers to all four checks (make generate impact, other project changes, CRD considerations, and related PR links for host/member operators if applicable).

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically summarizes the main change: introducing account-verifier response types and values to the API.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud