feat(syntax): detect languages from shebangs - #360
Merged
Conversation
Contributor
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f1a1337c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extensionless scripts currently have no automatic syntax selection even when their first line names an interpreter. This change detects languages from shebangs after existing filename and extension associations, so a file named
scriptbeginning with#!/usr/bin/env -S bash -eugets Bash highlighting and syntax-aware editing.Adds configurable
languages.<id>.shebangs, bounded first-line detection, commonenvforms and numeric interpreter versions. Editor buffers, eligible previews, and diff sides use the same detector; edits and language reloads refresh the selected syntax. Manual syntax selection retains precedence. Zsh continues to use the bundled Bash grammar. LSP routing remains filename-based; quoted commands and arbitrary wrappers are outside this parser's scope.Python pack interpreter metadata is a separate follow-up in
codersauce/red-language-packs; this PR provides the detector and configuration support it needs.How to Test
#!/usr/bin/env -S bash -eufollowed byif true; then echo hello; fi. Open it with this build: Bash syntax should be highlighted without setting executable permissions. Scroll below the first line and confirm highlighting persists.:syntax fishand then:syntax offto verify manual selection and disabling. A recognized.rsfilename must still select Rust even with a Bash shebang.cargo test --lib shebang: all five tests should pass, covering detection, registered interpreters, live reload, offscreen edits, manual selection, and preview cache invalidation.Validated locally: the five shebang tests, 70 highlighter tests (
cargo test --lib highlighter::tests), two preview tests (cargo test --lib preview_syntax_highlighting), formatting, andcargo clippy --all-targets --all-features -- -D warnings. The interactive steps above are reviewer instructions, not a claimed manual smoke test.