fix(session): support symlinked config directories - #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A symlinked
~/.config/redcan load configuration, but session snapshots fail to save because the snapshot store rejects symlinked path components. This leaves users with dotfile-managed config directories without session recovery data.What
Resolve the configured directory to its physical path before selecting the
sessionsroot at editor startup. Both snapshot writes and--resumeuse that path. The snapshot store still rejects symlinks withinsessionsand its owner directories, as enforced by its directory traversal.How to Test
redto a writable config directory, then launchredand exit normally. Confirmsessions/editor-*/latest.jsonappears in the target directory without a snapshot failure warning.red --resumewith the same config path and confirm it loads the saved session.sessionsitself a symlink. Confirm Red still rejects that session root.Targeted test passed:
cargo test --bin red session_root_resolves_a_symlinked_config_directory.