fix(startup): avoid first-launch config warning - #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On a fresh launch, Red loads embedded defaults when
config.tomlis absent. The defaultred.logis opened before~/.config/redexists, however, so startup reports aCFG303configuration problem and disables logging. Session setup creates the directory later, leaving a misleading warning on the first run.What
Create the configuration directory at the start of interactive editor startup, before loading runtime configuration.
config.tomlremains optional; Red still creates the starter file only when the user requests it.Add a regression test that launches Red with an empty
XDG_CONFIG_HOMEand checks that the default log opens without creatingconfig.toml.How to Test
XDG_CONFIG_HOMEto a fresh empty directory and launch the builtredin a terminal.red/red.logexists andred/config.tomlhas not been created unless you choose the starter config.Targeted test:
cargo test --test first_launch(passed).