chore(marketplace): switch to websocket #1166
Conversation
I am still exploring the issue, I am not sure how to reproduce it. |
2-towns
force-pushed
the
chore/re-enable-hardhat-websocket
branch
from
89b8fdc to
b6e6596
Compare
|
Actually, I have (I think 😅) a better idea - what about adding this functionality (automatically resubscriptions) directly to the nim-ethers under compile flag? No hacky private property access needed. It will be cleanly turned on only when the nim-ether's user needs... IMHO better then this. |
2-towns
force-pushed
the
chore/re-enable-hardhat-websocket
branch
from
6bf37ac to
c65b2cd
Compare
| @@ -23,6 +23,10 @@ ethersuite "On-Chain Clock": | |||
| let future = (getTime() + 42.years).toUnix | |||
| discard await ethProvider.send("evm_setNextBlockTimestamp", @[%future]) | |||
| discard await ethProvider.send("evm_mine") | |||
|
|
|||
| # Ensure that state updates are sync with WS | |||
| discard await ethProvider.getBlock(BlockTag.latest) | |||
There was a problem hiding this comment.
How does fetching the latest block ensure state updates are synchronous?
There was a problem hiding this comment.
I am not sure I was gonna to ask for a review.
But my guess is that with Websocket, since it is asynchronous and does not wait for the state update, the client might not immediately reflect the new block's state after evm_mine, so we need to get the latest block to ensure the client is synced with the blockchain.
There was a problem hiding this comment.
@emizzle are these changes okay for you ?
2-towns
force-pushed
the
chore/re-enable-hardhat-websocket
branch
from
3ba1c77 to
0f81b4d
Compare
2-towns
force-pushed
the
chore/re-enable-hardhat-websocket
branch
2 times, most recently
from
d3912db to
4087153
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Linea is supporting only Websocket.
So it would be better to use it in our testing.
Depends on codex-storage/nim-ethers#112.