Skip to content

chore(marketplace): use hardhat ignition #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

chore(marketplace): use hardhat ignition #1195

wants to merge 6 commits into from

Conversation

2-towns
Copy link
Contributor

@2-towns 2-towns commented Apr 15, 2025

This PR update the contracts module in order to use hardhat ignition for deployments and replace the deleted increaseAllowance by allowance / approve functions.

@markspanbroek
Copy link
Member

I ran into the same problem with #1196 and solved it with a lock (94236ca) to ensure that we don't get any race conditions while updating the allowance.

@2-towns
Copy link
Contributor Author

2-towns commented Apr 16, 2025

I ran into the same problem with #1196 and solved it with a lock (94236ca) to ensure that we don't get any race conditions while updating the allowance.

Thanks !

@2-towns 2-towns force-pushed the chore/hardhat-ignition branch from 1f2caf1 to bb505db Compare April 17, 2025 13:41
@2-towns 2-towns marked this pull request as ready for review April 18, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2-towns @markspanbroek