Fix api validation test #1201
Open
Fix api validation test #1201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows the codex node did not shut down properly after this test finished.
markspanbroek
force-pushed
the
fix-api-validation-test
branch
from
cee95dd to
d6f7fb3
Compare
|
Ugh, I think the reason @2-towns did this was to make the API tests faster. Do we want to revert it? Or maybe we add proper cleanup? Guess this is a bit of a philosophical discussion too: stopping/starting the node on every test will give you perfect isolation but make things significantly slower. OTOH not doing that may provide you some nice wtf moments as the one you just went through @markspanbroek. |
|
There's a lot of integration tests improvements lingering in the parallel integration tests branch, particularly regarding tearing down tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an intermittent problem with other tests because the api validation test kept a codex node alive after it finishes.
Also includes a fix for an unrelated flaky market test, to make the CI pass.