Experiment with simple swarms #1205
Conversation
…ii)_ new blocks are received.
| except CancelledError: | ||
| trace "Advertisement loop cancelled. Exiting." | ||
|
|
||
| proc loadBlockKnowledge*(self: Swarm): Future[void] {.async: (raises: []).} = |
There was a problem hiding this comment.
I'm not sure this is needed, why duplicate this if it is already in the blockstore? If you're worried about hitting the repostore too oftne, then we can always put a cache of some sort in front?
| trace "Error updating pending block knowledge request state (peer dropped)", | ||
| peer = peer | ||
|
|
||
| proc handleBlockRequest( |
There was a problem hiding this comment.
I know this is an experiment, but we should be lazy with handling requests, so I would still put this behind some throttling mechanism, such as the asyncqueue.
dryajov
left a comment
dryajov
left a comment
There was a problem hiding this comment.
Overall, I'm liking this direction very much. I think this might be close to being ussable. One thing we need to keep in mind, is that we still want the ability to stream requests, as this is a really imoprtant use case. I don't think anything specifically prevents it in this implementation, but just making sure it's know :)
Not a real PR, just to keep the thing visible if someone's interested.