-
-
Notifications
You must be signed in to change notification settings - Fork 3
Blankie 1.1 (Custom Sounds, Universal App) #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
codybrom
wants to merge
189
commits into
main
Choose a base branch
from
v1.1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aptiveContentView and ContentView
- Updated Preset validation to only require built-in sounds, allowing custom sounds to be optional. - Added EditSoundSheet for editing custom sound properties, including name and icon selection. - Introduced ImportSoundSheet for importing audio files with icon selection and error handling. - Created CustomSoundsView to manage custom sounds, including import, edit, and delete functionalities. - Integrated new sheets into the BlankieToolbar for easy access to sound management features.
Adds custom sound management features while maintaining cross-platform support
Merge Universal App into Custom Sounds
…entation - Created new Xcode schemes for CarPlay: "Blankie (Universal)" and "Blankie (iOS with CarPlay)". - Implemented CarPlay scene delegate in `CarPlaySceneDelegate.swift`. - Developed `CarPlayInterface` for managing the CarPlay UI and interactions. - Updated `AudioManager` to handle playback state changes for CarPlay. - Added localization strings for CarPlay connectivity. - Documented CarPlay implementation details in `CARPLAY.md`.
…r and PresetManager
- Implemented data migration to app group for UserDefaults and SwiftData. - Refactored CarPlay interface initialization to ensure proper app setup. - Added functionality to load custom sounds by their IDs. - Enhanced thumbnail caching for CarPlay presets. - Introduced a new method for importing custom sounds with pre-analyzed metadata. - Improved error handling and logging during data migration. - Updated UserDefaults access to use shared instance for app group. - Cleaned up orphaned sound entries in default sound order. - Added support for caching artwork thumbnails for CarPlay. - Refactored various audio and preset management functionalities for better performance and maintainability.
- Introduced a shared UserDefaults instance to streamline access across app group and standard UserDefaults. - Added AppDataMigrator to handle one-time migration of UserDefaults and SwiftData to app group. - Updated various managers and models to utilize the new shared UserDefaults instance. - Implemented debouncing for rapid updates in NowPlayingManager and SoundCustomizationManager to optimize performance. - Enhanced logging and removed verbose print statements for better clarity during debugging. - Consolidated SwiftData migration logic into AppDataMigrator, removing the old SwiftDataMigration utility. - Cleaned up legacy code and ensured all relevant data is migrated to the new structure.
…lization improvements
…ith existing databases
- Introduced a new icon configuration file for the classic app icon. - Updated AboutView to support alternate app icons, allowing users to choose between Default, Classic, and Beta icons. - Improved icon loading logic to handle both display assets and legacy PNG sets. - Added a tip for changing the app icon and refined the layout of the AboutView for better user experience. - Implemented a new icon chooser sheet for iOS, enhancing accessibility and usability.
- Added `AnimatedArtworkRef` and `staticArtworkPath` to the `Preset` model. - Introduced `BlankieAnimatedArtwork.swift` for publishing animated artwork to Now Playing. - Created `AnimatedArtworkFileStore.swift` for managing animated artwork files. - Updated `CreatePresetSheet` and `EditPresetSheet` to include animated artwork selection. - Added `AnimatedArtworkPicker` for user interface to choose animated artwork. - Implemented `prepare_loop.sh` script for processing video files into required formats. - Updated app settings to include a toggle for enabling/disabling animated backgrounds. - Added migration notes and QA guidelines for the new animated artwork feature.
…deos and update related components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close #1, #10, #12, #23, #46