-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Branch Selection for coffee_install()
#242
Changes from 1 commit
e91a987
9a97397
7e301a2
d77053b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
Signed-off-by: Tarek <tareknaser360@gmail.com>
There are no files selected for viewing
Unchanged files with check annotations Beta
//! from a plugin manager point of view. | ||
use std::fmt::{self, Display}; | ||
use log; | ||
Check warning on line 5 in coffee_lib/src/plugin.rs
|
||
use serde::{Deserialize, Serialize}; | ||
use tokio::process::Command; | ||
use std::any::Any; | ||
use async_trait::async_trait; | ||
use git2; | ||
Check warning on line 4 in coffee_github/src/repository.rs
|
||
use log::debug; | ||
use tokio::fs::File; | ||
use tokio::io::AsyncReadExt; |
//! Coffee mod implementation | ||
use std::collections::HashMap; | ||
use std::fmt::Debug; | ||
use std::vec::Vec; | ||
Check warning on line 4 in coffee_core/src/coffee.rs
|
||
use tokio::fs; | ||
use async_trait::async_trait; | ||
use clightningrpc_common::client::Client; | ||
use clightningrpc_common::json_utils; | ||
use clightningrpc_conf::{CLNConf, SyncCLNConf}; | ||
use log; | ||
Check warning on line 11 in coffee_core/src/coffee.rs
|
||
use serde::de::DeserializeOwned; | ||
use serde::{Deserialize, Serialize}; | ||
use serde_json::json; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should not document every single command possibility otherwise our documentation will be always uncompleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. I can remove this section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but we should came up with a way to document optional parameters