Skip to content

Fix typing of DatapointSubscription.time_series_count #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2025

Conversation

erlendvollset
Copy link
Collaborator

  • Make DatapointsSubscription.time_series_count nullable as per service contract
  • Bump version and update changelog

Description

Please describe the change you have made.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@erlendvollset erlendvollset requested review from a team as code owners April 8, 2025 07:09
@erlendvollset erlendvollset changed the title fix timeseries count Fix typing of DatapointSubscription.time_series_count Apr 8, 2025
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.53%. Comparing base (9ae8db0) to head (1622dd8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2147      +/-   ##
==========================================
- Coverage   90.53%   90.53%   -0.01%     
==========================================
  Files         158      158              
  Lines       23753    23753              
==========================================
- Hits        21505    21504       -1     
- Misses       2248     2249       +1     
Files with missing lines Coverage Δ
cognite/client/_version.py 100.00% <100.00%> (ø)
...te/client/data_classes/datapoints_subscriptions.py 87.61% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erlendvollset erlendvollset requested a review from a team April 8, 2025 08:45
Copy link
Contributor

@psalaberria002 psalaberria002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦄

@psalaberria002 psalaberria002 added the risk-review-done Risk review done -- ready for further action (fix or merge) from the submitter label Apr 8, 2025
@erlendvollset erlendvollset added this pull request to the merge queue Apr 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 10, 2025
@erlendvollset erlendvollset added this pull request to the merge queue Apr 13, 2025
Merged via the queue into master with commit 13598ad Apr 13, 2025
17 checks passed
@erlendvollset erlendvollset deleted the fix-timeseries-count branch April 13, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
risk-review-done Risk review done -- ready for further action (fix or merge) from the submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants