Skip to content

move static methods out of class - #23

Merged
christianrauch merged 1 commit into
mainfrom
static_methods
Jul 11, 2026
Merged

move static methods out of class#23
christianrauch merged 1 commit into
mainfrom
static_methods

Conversation

@christianrauch

@christianrauch christianrauch commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

With the command line parsing not depending on a class member, we can move these functions as static functions out of the 'MesonBuildTask' class.

@codecov-commenter

codecov-commenter commented Jul 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.71%. Comparing base (194e14a) to head (bb463ed).

Files with missing lines Patch % Lines
colcon_meson/build.py 0.00% 29 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   20.71%   20.71%           
=======================================
  Files           2        2           
  Lines         251      251           
  Branches       51       51           
=======================================
  Hits           52       52           
  Misses        192      192           
  Partials        7        7           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

With the command line parsing not depending on a class member, we can move
these functions as static functions out of the 'MesonBuildTask' class.
@christianrauch
christianrauch merged commit fce5de7 into main Jul 11, 2026
64 checks passed
@christianrauch
christianrauch deleted the static_methods branch July 11, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants