Update to next version of gitlab-runner-rs #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColinKinloch
changed the title
ColinKinloch
force-pushed
the
gitlab_runner_next
branch
from
e66a22b to
cfbab52
Compare
When tests fail the logging from gitlab-runner-rs is likely useful. * trace for obs_gitlab_runner * debug for gitlab_runner * warn for anything else
Print attempt number on subsequent commit attempts
GitlabLayer is replaced with with Filtered<GitlabLayer, _, _> in gitlab-runner-rs 0.0.9. Replacing `with_tracing` with a macro simplifys resolving trait bounds.
* Use `HashSet` to avoid duplicate artifacts, implement hashing and equality based on the file path. * Store artifacts using `NamedTempFile`s and refer to them using their paths. * Add `ObsArtifact` type for storing artifacts either in memory or as files, 0.0.8 adds the `UploadableFile` type for actifacts. * Add explicit lifetime rather than `'static` to `ArtifactDirectory::Reader` to avoid having to copy in many cases. * In the default implementation of the `ArtifactDirectory` trait use `get_file_or_none` rather than `get` for `get_file`. This commit requires async `UploadableFile::get_data` from gitlab-runner-rs 0.2.0 in order to open artifacts files.
This will delete them once the job is completed.
Update zip to 2.2.3
This makes `UploadableFile::get_data` async
ColinKinloch
force-pushed
the
gitlab_runner_next
branch
from
d0fdb17 to
f076056
Compare
|
Currently a few test are failing when I run them locally. |
|
The issue also exists on the |
you have a file descriptor limit of 1024? that's very oldschool, on modern systems it's essentially unlimited |
|
I assume it's the default in fedora. 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on collabora/gitlab-runner-rs#82
You can test this by uncommenting the following lines in
Cargo.toml:General
debugmessages fromgitlab-runner-rsandtracemessages by default.This allows tests failing in
gitlab-runner-rsgive useful debug info.v0.0.8
UploadableFileCurrently obs-glr stores artifacts using
tempfile::tempfile()which removes the file on close. This means it's passing aroundtokio::Files which share their seek position between copies when cloned.I've switched this out for storing
PathBufs.'staticlifetimes for artifact readersv0.0.9
Layer<S>forGitlabLayer::new()with_tracingmacro to avoid trait bounds