fix revision access failing when limit is enabled #639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When limit is enabled and reached, if a field was initialized but never changed, it will be merged and result in a audit like that:
(notice the
action: "update"
and the value in "name" beeing a single value, not an array)and then, when trying to access a revision, we get this error:
So in this fix, i added a failing test, then fixed it by changing
attrs[attr] = (action == "update" ? values.last : values)
toattrs[attr] = (values.is_a?(Array) ? values.last : values)