Add hex support #200
Merged
Add hex support #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spenserblack
requested changes
Feb 28, 2025
spenserblack
approved these changes
Mar 3, 2025
|
Thank you! |
|
Tbh I don't understand the semver issue, I didn't add or change any |
No worries, you didn't do anything wrong. It reports a failure whenever the semver is not bumped appropriately from the last release, as far as I understand it. So it will almost always fail on new feature PRs, since we don't bump the version until right before release. Or, more accurately, bumping the version triggers a release, so we can't bump it until we're ready to release. |
Because we assert length, we can index directly into strings. Also, since we're already checking for the string to start with `#`, we can drop that first character so simplify parsing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for hex strings (
"#abc"or"#abcdef") in place of color names when using.color(...). For exampleThe case of the hex string is ignored. If an invalid hex string is passed (including missing
#), the color defaults to white.