-
Notifications
You must be signed in to change notification settings - Fork 30
SimpleTable with Record, w/o marker class #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bishabosha
wants to merge
17
commits into
com-lihaoyi:main
Choose a base branch
from
bishabosha:feature/table-named-tuples-new-hierarchy-record3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SimpleTable with Record, w/o marker class #82
bishabosha
wants to merge
17
commits into
com-lihaoyi:main
from
bishabosha:feature/table-named-tuples-new-hierarchy-record3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evidence not to go with plain named tuples further wip work with projecting named tupke type into the record
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compared to the initial PR #81, this trades in dropping the marker class for a more complex implementation where the type of the Expression has to be re-computed on each
.select
,.insert
etc, and passed as a type parameter to the record class. This also relies upon transparent inline and macros to compute the types (IntelliJ issue maybe?)However as far as I know IntelliJ doesn't support match types either so probably a moot point
inside an expression, you have the type
SimpleTable.Record[City, (name : Expr[String], population : Expr[Int], mayor : SimpleTable.Record[Person, (name : Expr[String], age : Expr[Int])])]
, inferred by metals