Add flash walkthrough video#209
Closed
weishen612 wants to merge 1 commit into
Closed
Conversation
Author
|
Closing this draft because I’m not continuing it without a real-device walkthrough. The current implementation does not fully match the issue’s intended deliverable, so I do not want to keep this open as a bounty submission. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #128
Notes
The video uses the existing flash.comma.ai visual language and repository assets, plus self-made animation and procedural audio. It avoids showing a fake completed flash; the walkthrough stops short of claiming a real device was flashed.
Video asset:
public/flash-walkthrough.mp4Testing
npx --yes bun installnpx --yes bun run test src/app/App.test.jsx --runnpx --yes bun run buildKnown unrelated baseline note:
npx --yes bun run test --runcurrently fails insrc/utils/manifest.test.jsbecause the remote manifest returns 32 images while the test expects 33. The app-focused walkthrough test passes.