Skip to content

Conversation

TheSecurityDev
Copy link
Contributor

@TheSecurityDev TheSecurityDev commented Oct 14, 2025

We can just click through the training guide and take a screenshot at the final step to help ensure it's all working. Each step is just an image so it will test most of the functionality this way without having to do each step individually.

@Copilot Copilot AI review requested due to automatic review settings October 14, 2025 21:32
@github-actions github-actions bot added the ui label Oct 14, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a screenshot test for the onboarding training guide by automating clicks through all training steps and capturing the final state. This provides visual regression testing for the onboarding flow without needing individual step-by-step tests.

  • Implements setup_onboarding function that navigates through the entire training guide
  • Adds the new test case to the CASES dictionary for screenshot generation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

github-actions bot commented Oct 14, 2025

raylib UI Preview

onboarding_completion : $${\color{cyan}\text{NEW}}$$
All Screenshots

@TheSecurityDev
Copy link
Contributor Author

TheSecurityDev commented Oct 15, 2025

It seems to be broken now and I don't understand why.

Ok, importing the step rects from the onboarding file at the top of the file affected the params for the other screenshots for some reason.

@TheSecurityDev
Copy link
Contributor Author

The issue is ui_state.py is imported from onboarding.py, and that initializes the params and resets everything. I could separate the step rects out into another file.

Copy link
Contributor Author

@TheSecurityDev TheSecurityDev Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate out this file since importing the steps from onboarding.py from the test causes the params to be changed due to importing ui_state it seems

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a better way to do this?

@TheSecurityDev TheSecurityDev changed the title Add screenshot test for onboarding raylib screenshots: onboarding Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants