Skip to content

Conversation

@TheSecurityDev
Copy link
Contributor

@TheSecurityDev TheSecurityDev commented Oct 15, 2025

Quick fix for the duplicate period key not working. We'll just replace the first one with either underscore/hypen, depending on which one isn't already present. I think underscore would be more useful for things like Github username anyway, so it's nice to have it without going all the way into symbols.

If anyone has a new symbol suggestion, let me know. We could also adjust the layout or make the space bar wider instead.

Copilot AI review requested due to automatic review settings October 15, 2025 15:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a duplicate period key issue in the on-screen keyboard by replacing duplicate period keys with underscore and hyphen in the numbers and specials layouts respectively.

Key Changes

  • Replace duplicate period key with underscore in the numbers layout
  • Replace duplicate period key with hyphen in the specials layout
  • Maintain existing period key availability in the bottom row of both layouts

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added the ui label Oct 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025

raylib UI Preview

All Screenshots

@TheSecurityDev
Copy link
Contributor Author

#36342 would be nice for things like this 🥲

@maxime-desroches maxime-desroches merged commit 4489517 into commaai:master Oct 22, 2025
14 checks passed
@TheSecurityDev TheSecurityDev deleted the remove-duplicate-period branch October 22, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants