ci: fix flaky macOS build #36363
Closed
ci: fix flaky macOS build #36363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes flaky macOS builds by adding OpenSSL relinking steps to the setup script. The change addresses inconsistent build failures where OpenSSL@3 dependencies weren't properly linked.
- Adds OpenSSL@3 unlinking and relinking steps to stabilize macOS builds
- Uses
|| trueto prevent failure if OpenSSL@3 isn't currently linked - Forces overwrite during relinking to resolve potential conflicts
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
1 similar comment
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlink and relink
openssl@3inmac_setup.sh. Otherwise, it's hit or miss with my PRs whether the macOS build will succeed.Failure example: https://github.com/commaai/openpilot/actions/runs/18534765840/job/52826803925?pr=36342