lint: Add PLE rule to ruff #36595
Open
lint: Add PLE rule to ruff #36595
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
There's a few others that could be useful, such as PLW, but those have lots of violations in the code currently |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the DirectoryTarChunkReader.__init__ method and enables Pylint Error rules in the linter configuration to catch similar issues.
- Removed incorrect
returnstatement from__init__method inDirectoryTarChunkReaderclass - Enabled "PLE" (Pylint Error) rules in Ruff linter configuration to prevent similar errors
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| system/updated/casync/casync.py | Fixed incorrect return statement in DirectoryTarChunkReader.__init__ method |
| pyproject.toml | Added "PLE" (Pylint Error rules) to Ruff linter select list to catch errors like returning values from __init__ |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the following Ruff lint rule set (Pylint errors):
https://docs.astral.sh/ruff/rules/#error-ple
Also fixes the single error that was raised from this.