feat(replay): migrate onroadevents, cleanup

[greatgitsby]

we will use these onroad events in mici UI, and the demo route still uses old deprecated onroadevents

modularized into separate methods since onroad events is a nasty migration

[greatgitsby]

this is kinda messy. i see we only want to run migration on controlsState to selfdriveState if there are no selfdriveState messages in the segment.

i think it's probably best to have a separate method that always runs the onroadEventsDEPRECATED migration and leave the rest of the logic alone.

[deanlee]

It might be cleaner and easier to maintain if we use a single mapping table instead of a massive switch statement.

Here’s a simplified approach using a small macro to reduce redundancy and improve readability:

using OldEventName = cereal::OnroadEventDEPRECATED::EventName;
using NewEventName = cereal::OnroadEvent::EventName;

#define MAP_EVENT_NAME(name) {OldEventName::name, NewEventName::name}

static const std::unordered_map<OldEventName, NewEventName> event_name_map = {
  MAP_EVENT_NAME(CAN_ERROR),
  MAP_EVENT_NAME(STEER_UNAVAILABLE),
  MAP_EVENT_NAME(WRONG_GEAR),
  MAP_EVENT_NAME(DOOR_OPEN),
  ...
};

[greatgitsby]

cool! let me try this out