Skip to content

ui: only import layouts that are used #36648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+8 −8
Closed

ui: only import layouts that are used #36648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec6d242
refactor: conditionally import main layout
TheSecurityDev Nov 19, 2025
c8b467b
refactor: move imports inside main function for reset, setup, and upd…
TheSecurityDev Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions selfdrive/ui/ui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
from openpilot.system.hardware import TICI
from openpilot.common.realtime import config_realtime_process, set_core_affinity
from openpilot.system.ui.lib.application import gui_app
from openpilot.selfdrive.ui.layouts.main import MainLayout
from openpilot.selfdrive.ui.mici.layouts.main import MiciMainLayout
from openpilot.selfdrive.ui.ui_state import ui_state


Expand All @@ -16,8 +14,10 @@ def main():

gui_app.init_window("UI")
if gui_app.big_ui():
from openpilot.selfdrive.ui.layouts.main import MainLayout
main_layout = MainLayout()
else:
from openpilot.selfdrive.ui.mici.layouts.main import MiciMainLayout
main_layout = MiciMainLayout()
main_layout.set_rect(rl.Rectangle(0, 0, gui_app.width, gui_app.height))
for should_render in gui_app.render():
Expand Down
4 changes: 2 additions & 2 deletions system/ui/reset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
#!/usr/bin/env python3
from openpilot.system.ui.lib.application import gui_app
import openpilot.system.ui.tici_reset as tici_reset
import openpilot.system.ui.mici_reset as mici_reset


def main():
if gui_app.big_ui():
import openpilot.system.ui.tici_reset as tici_reset
tici_reset.main()
else:
import openpilot.system.ui.mici_reset as mici_reset
mici_reset.main()


Expand Down
4 changes: 2 additions & 2 deletions system/ui/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
#!/usr/bin/env python3
from openpilot.system.ui.lib.application import gui_app
import openpilot.system.ui.tici_setup as tici_setup
import openpilot.system.ui.mici_setup as mici_setup


def main():
if gui_app.big_ui():
import openpilot.system.ui.tici_setup as tici_setup
tici_setup.main()
else:
import openpilot.system.ui.mici_setup as mici_setup
mici_setup.main()


Expand Down
4 changes: 2 additions & 2 deletions system/ui/updater.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
#!/usr/bin/env python3
from openpilot.system.ui.lib.application import gui_app
import openpilot.system.ui.tici_updater as tici_updater
import openpilot.system.ui.mici_updater as mici_updater


def main():
if gui_app.big_ui():
import openpilot.system.ui.tici_updater as tici_updater
tici_updater.main()
else:
import openpilot.system.ui.mici_updater as mici_updater
mici_updater.main()


Expand Down