uploader: the 12h metered delay never applied to boot and crash logs - #38819
Open
singhharsh1708 wants to merge 1 commit into
Open
uploader: the 12h metered delay never applied to boot and crash logs#38819singhharsh1708 wants to merge 1 commit into
singhharsh1708 wants to merge 1 commit into
Conversation
Contributor
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
singhharsh1708
force-pushed
the
uploader-metered-boot-logs
branch
from
September 8, 2026 18:11
f0a8d6a to
5388742
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 12 hour hold off that keeps boot and crash logs off a metered connection has never run. immediate_folders is ["crash/", "boot/"] with trailing slashes, because its other use further down is a substring test against a full key. The check at line 119 is an exact membership test against logdir, which comes from os.listdir and so is "boot" or "crash", never with a slash, so it is always False.
On a metered connection that means a bootlog or crashlog is uploaded immediately over cellular instead of waiting up to 12 hours for a chance at wifi. It has behaved this way since #31045, which is both where the check was added and where the loop variable was renamed from logname to logdir.
Comparing with the slash matches how immediate_folders is defined and leaves the substring use at line 131 alone. I also added a test, since the existing ones only ever call list_upload_files(metered=False), which is why this went unnoticed.