Skip to content

move can ignition to opendbc#2396

Merged
elkoled merged 6 commits into
masterfrom
move-can-ignition
May 13, 2026
Merged

move can ignition to opendbc#2396
elkoled merged 6 commits into
masterfrom
move-can-ignition

Conversation

@elkoled
Copy link
Copy Markdown
Contributor

@elkoled elkoled commented May 1, 2026

opendbc PR needs to be merged before: commaai/opendbc#3370

Move ignition_can_hook from panda can_common.h to opendbc ignition.h

Validation
Replayed routes from commaCarDataset through panda and opendbc can-ignition hooks for byte-identical output per frame.

Brand Model Route
GM BUICK_REGAL d3e16b209dc1807a/000000c5--69693a8087
GM CADILLAC_ESCALADE defd7f8491ad9254/0000007b--901c1643de
GM CADILLAC_ESCALADE_ESV_2019 d0a547a2efe445ba/00000002--b65614d603
GM CADILLAC_XT4 923c49a3a2bb6ace/00000027--0b264ff599
GM CHEVROLET_BOLT_EUV 09fbf79217ecf8be/2024-05-27--19-03-45
GM CHEVROLET_EQUINOX b82c5b6d3d4ad9f6/00000121--763f681dac
GM CHEVROLET_SILVERADO 1c02b454e6265e68/2025-04-04--13-30-17
GM CHEVROLET_TRAVERSE fb4b8ab27080025d/00000041--2cb71e0191
GM CHEVROLET_VOLT fed69e3ca8d279dc/00000644--4da2b1bf01
GM CHEVROLET_VOLT_2019 c90a7d888e9cb72b/00000014--1d901b4c93
GM GMC_ACADIA df51b2195de66a9b/0000002b--4804d98571
GM GMC_YUKON b513af7447934108/00000008--94b1e36dd5
Mazda MAZDA_CX5 9f46a57f430101ea/00000008--313148e315
Mazda MAZDA_CX5_2022 8a9dac95d24c4e8d/2025-04-18--05-38-13
Mazda MAZDA_CX9_2021 f93472b242797ef0/00000000--48ac3b0974
Rivian RIVIAN_R1 ff6995b1cb7a5243/00000136--7349553e54
Tesla TESLA_MODEL_3 fa2c6a0d5a103101/00000017--ea70a24924
Tesla TESLA_MODEL_Y fe762237b0631835/00000036--91b82f180c

Tests
100% coverage for all brands in opendbc/safety/tests/test_ignition.py:

  • ignition on/off, wrong bus, unknown addr
  • Rivian/Tesla counter gating

Adding new ignition hook

  1. Add can ignition block in ignition.h
  2. Add _<brand>_msg() helper and tests to test_ignition.py

Merge sequence
opendbc -> panda -> openpilot bump

temp: point to opendbc PR
@elkoled elkoled force-pushed the move-can-ignition branch from 697bd88 to 6c5a59b Compare May 1, 2026 21:43
@elkoled elkoled marked this pull request as ready for review May 13, 2026 17:38
@elkoled elkoled merged commit 7ffc916 into master May 13, 2026
4 checks passed
@elkoled elkoled deleted the move-can-ignition branch May 13, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant