Skip to content

Add "stages" explicitly to the hook example #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

matheuscas
Copy link
Contributor

Description

Add "stages" explicitly to the hook example

As mentioned here: #177 (comment), without the stages explicitly set, the hook always fails.

Checklist

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

The hook should work when the message is correct on commit stage.

Steps to Test This Pull Request

  1. Add the hook as it is today.
  2. Write a correct commit such as chore or feat
  3. See the hook failing

Additional context

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (120d514) to head (e7862e6).
Report is 560 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1356      +/-   ##
==========================================
+ Coverage   97.33%   97.55%   +0.22%     
==========================================
  Files          42       55      +13     
  Lines        2104     2622     +518     
==========================================
+ Hits         2048     2558     +510     
- Misses         56       64       +8     
Flag Coverage Δ
unittests 97.55% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

As mentioned here: commitizen-tools#177 (comment), without the stages explicitly set, the hook always fails.
@Lee-W Lee-W merged commit 43ee8a0 into commitizen-tools:master Feb 10, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants