Add CWLParameterContext as a TypedDict
#392
Merged
+116
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-c
requested changes
Dec 12, 2025
Member
mr-c
left a comment
mr-c
left a comment
There was a problem hiding this comment.
make remove_unused_imports should fix it
GlassOfWhiskey
force-pushed
the
modernize-types-part-2
branch
from
7afbd15 to
c8dd813
Compare
This commit further modernizes the CWL type system. It also adds a `TypedDict` class to represent the CWL parameter context used for expression evaluation.
mr-c
force-pushed
the
modernize-types-part-2
branch
from
c8dd813 to
342bbea
Compare
mr-c
approved these changes
Dec 12, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #392 +/- ##
==========================================
+ Coverage 34.64% 34.66% +0.02%
==========================================
Files 30 30
Lines 35400 35412 +12
Branches 9538 9538
==========================================
+ Hits 12263 12275 +12
Misses 20257 20257
Partials 2880 2880 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit further modernizes the CWL type system. It also adds a
TypedDictclass to represent the CWL parameter context used for expression evaluation.