-
-
Notifications
You must be signed in to change notification settings - Fork 22
Update to connexion 3 #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
a3ddd7e
to
9263298
Compare
@stxue1 @DailyDreaming I rebased this now that #135 is merged and we have a proper CI again. Can you investigate the test failures? |
Co-authored-by: Michael R. Crusoe <[email protected]>
Head branch was pushed to by a user without write access
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
==========================================
+ Coverage 71.39% 71.61% +0.21%
==========================================
Files 5 4 -1
Lines 451 391 -60
==========================================
- Hits 322 280 -42
+ Misses 129 111 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This should resolve #134
This also reinforces workflow status polling for Toil.