Skip to content

Update to connexion 3 #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

stxue1
Copy link

@stxue1 stxue1 commented Mar 21, 2025

This should resolve #134

This also reinforces workflow status polling for Toil.

Copy link
Collaborator

@DailyDreaming DailyDreaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DailyDreaming DailyDreaming enabled auto-merge March 21, 2025 19:44
@mr-c mr-c force-pushed the update-connexion branch 2 times, most recently from a3ddd7e to 9263298 Compare March 24, 2025 15:48
@mr-c
Copy link
Member

mr-c commented Mar 24, 2025

@stxue1 @DailyDreaming I rebased this now that #135 is merged and we have a proper CI again.

Can you investigate the test failures?

@mr-c mr-c requested a review from DailyDreaming March 24, 2025 15:49
Co-authored-by: Michael R. Crusoe <[email protected]>
@mr-c mr-c force-pushed the update-connexion branch from 9263298 to db62d5f Compare March 24, 2025 16:10
auto-merge was automatically disabled April 3, 2025 23:11

Head branch was pushed to by a user without write access

Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 20.83333% with 19 lines in your changes missing coverage. Please review.

Project coverage is 71.61%. Comparing base (6ead116) to head (712a36f).

Files with missing lines Patch % Lines
wes_service/util.py 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
+ Coverage   71.39%   71.61%   +0.21%     
==========================================
  Files           5        4       -1     
  Lines         451      391      -60     
==========================================
- Hits          322      280      -42     
+ Misses        129      111      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No support for Connexion 3, so a vulnerable Werkzeug is required
3 participants