fix(silo): Handle JSON API returns single doc#122
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the jsonApiProcessor to handle JSON-API responses where data is a single resource object (not an array), and adds a regression test to cover that behavior.
Changes:
- Extend the JSON-API envelope typing so
datamay be a single object or an array. - Normalize
datato an array before inserting documents into the store. - Add a new Vitest case ensuring single-object
datais inserted correctly.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/silo/src/processors/json-api.ts | Accept data as object-or-array and normalize to an iterable list before inserting. |
| packages/silo/tests/processors/json-api.test.ts | Add test coverage for single-object data envelopes. |
| .oxlintrc.json | Adjust lint configuration related to nested ternaries (but currently introduces invalid strict JSON via trailing commas). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+118
to
+122
| const data = envelope.data | ||
| ? Array.isArray(envelope.data) | ||
| ? envelope.data | ||
| : [envelope.data] | ||
| : []; |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 58 58
Lines 2055 2056 +1
Branches 484 485 +1
=========================================
+ Hits 2055 2056 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.