fix: enhance back navigation in NotFoundPage component and remove unused deps #9341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `framer-motion` to version `12.23.12` in `package.json` and `bun.lock`. - Removed unused dependencies: `fuse.js`, `react-code-blocks`, `react-datepicker`, `pocketbase`, `simple-icons`. - Refactored import in `number-ticker.tsx` to use `motion/react` instead of `framer-motion`. - Removed CSS import for `react-datepicker` in `page.tsx`.
- Modified the redirection logic in NotFoundPage to use the basePath variable. - Set default basePath to "ProxmoxVE" in site-config for improved routing consistency.
tremor021
previously approved these changes
Nov 22, 2025
MickLesk
previously approved these changes
Nov 22, 2025
michelroegl-brunner
previously approved these changes
Nov 22, 2025
Member
|
@BramSuurdje you got some merge conflicts to solve please, rest looks good. |
BramSuurdje
dismissed stale reviews from michelroegl-brunner, MickLesk, and tremor021
via
b1068c5
michelroegl-brunner
approved these changes
Nov 23, 2025
MickLesk
approved these changes
Nov 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Description
This pull request primarily focuses on cleaning up unused dependencies, updating the fallback behavior for the "Go Back" button on the Not Found page, and making minor configuration and import adjustments. The most important changes are summarized below:
Dependency Cleanup:
Removed several unused dependencies from
frontend/package.json, includingframer-motion,fuse.js,pocketbase,react-code-blocks,react-datepicker,react-simple-typewriter, andsimple-icons. This reduces bundle size and potential security risks.Updated imports in
number-ticker.tsxto usemotion/reactinstead offramer-motion, reflecting the dependency cleanup.Removed the import of
react-datepicker's CSS fromdata/page.tsx, since the dependency was removed.UX Improvements:
Configuration Updates:
basePathinsite-config.tsxfrom an empty string to"ProxmoxVE", ensuring a consistent fallback for routing and navigation.🔗 Related PR / Issue
Link: #
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.