fix double transformation in viewer #30
Conversation
|
why was this not an issue before? |
gonzalocasas
left a comment
gonzalocasas
left a comment
There was a problem hiding this comment.
Besides the need for an extra clarifying comment, and changelog, I guess it's good to go ;)
| # if i > 0: | ||
| # parent = objects[i - 1] | ||
| self.viewer.scene.add(obj, parent) | ||
| self.viewer.scene.instance_colors[obj.instance_color.rgb255] = obj |
There was a problem hiding this comment.
Even though it's (likely) a temporary fix, we should drop a quick comment in here explaining why this is like it is now
There was a problem hiding this comment.
Sorry I totally forgot about this PR until @chenkasirer reminded me today
That's a good point let me make this a issue so I remember to add it to the documentation of Viewer. And yes, there is a ModelObject and ElementObject, they basically recursively add their children at |
Not the perfect fix, but works for now.
The issue of the double transformation was because compas_robot as been calculating the
tranformationvalue as the aggregatedworldtransformation. So if we nest these joints in Viewer, the parent transformations got repeated applied. The fastest fix is that instead of nesting joints, we add them flatly under the robot object.