Add automated accessibility tests (jest-axe + cypress-axe) - #2690
Open
MustafaGood wants to merge 4 commits into
Open
Add automated accessibility tests (jest-axe + cypress-axe)#2690MustafaGood wants to merge 4 commits into
MustafaGood wants to merge 4 commits into
Conversation
Add accessible labels, status/alert live regions, global focus-visible, modal keyboard support, and main landmark in client-participation-alpha.
Associate form errors via aria-describedby and expose toggle state on visualization controls for screen readers.
Expose opinion-group chart name to assistive tech and announce selected group/statement outside the SVG.
Catch accessibility regressions with component axe tests and an e2e smoke; darken vote button colors to meet WCAG AA contrast.
MustafaGood
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client-participation-alphawith a11y tests for SurveyForm, EmailSubscribeForm, InviteCodeSubmissionForm, and Statemente2efor.statement-cardand.submit-form(critical/serious)Test plan
cd client-participation-alpha && npm test -- --testPathPatterns=a11ycd client-participation-alpha && npm run verify(or at least test + lint + build)cd e2e && CYPRESS_BASE_URL=https://localhost npm run test:a11y/alpha/52czbnk3jnand confirm Agree/Disagree remain clearly visibleNotes
feature/a11y-automated-tests52czbnk3jn(override:CYPRESS_A11Y_CONVERSATION_ID)