Address reviews to fix stale masks, prompt routing and device selection for interactive segmentation - #1310
Merged
Merged
Conversation
…on for interactive segmentation
…ctive segmentation
Collaborator
Author
|
Okay I'm currently convinced that this is in a good state now. I'll go ahead and merge this once the tests pass! (and continue other smaller improvements in a follow-up PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay all the reviews from @constantinpape have been taken care of now. Will check a few things, and then merge them (once the tests pass)!