Skip to content

Conversation

@nolanwhy
Copy link

Title says it all

@nolanwhy
Copy link
Author

this would be useful
Capture d’écran 2025-05-29 à 22 49 27

@befaci03
Copy link

befaci03 commented Oct 25, 2025

why like this, you should change it from main.ts in the openVM function

@dakrk
Copy link
Contributor

dakrk commented Oct 25, 2025

why like this, you should change it from main.ts in the openVM function

Setting maxLength from there does the exact same thing as what's already proposed anyway as it sets the element's maxlength attribute, except now it will be doing it redundantly each time you join a VM.

There's no need for it to be done that way at the moment, unless in the future the server actually announces the message limit it has been configured with.

@befaci03
Copy link

why like this, you should change it from main.ts in the openVM function

Setting maxLength from there does the exact same thing as what's already proposed anyway as it sets the element's maxlength attribute, except now it will be doing it redundantly each time you join a VM.

There's no need for it to be done that way at the moment, unless in the future the server actually announces the message limit it has been configured with.

yeah like when you connect to the vm, the server send ["vmattr", "maxmessagelength", "LENGTH_HERE"] by parsing it via GuacUtil and then adding the attribute in the chat input

@elijahr2411
Copy link
Member

There's no need for it to be done that way at the moment, unless in the future the server actually announces the message limit it has been configured with.

This is actually how I'd prefer to solve the issue but something simple like this is probably fine for now -- the obvious drawback to a bandaid fix like this appears if the server's max chat length ISN'T set to 100

befaci03 added a commit to befaci03/collab-vm-1.2-webapp-fixing that referenced this pull request Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants