Skip to content

feat(storage): report download throughput as per-step data via ctx.measure #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HeyGarrison merged 3 commits into from
Jul 30, 2026
Merged

feat(storage): report download throughput as per-step data via ctx.measure #258

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
178afb3
feat(storage): measure download throughput as per-step data
HeyGarrison Jul 30, 2026
8c50991
feat(benchmarks): emit ai-gateway token + browser-throughput action r…
HeyGarrison Jul 30, 2026
437c7ad
refactor(browser-throughput): record lifecycle via real ctx.step inst…
HeyGarrison Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions benchmarks/storage/storage-task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export function makeStorageTask(
const storageCache = new Map<string, Storage>();

return async function storageTask(ctx: TaskContext<StorageProviderConfig>): Promise<TaskResult> {
const { participant, step } = ctx;
const { participant, step, measure } = ctx;
const timeout = participant.timeout ?? 30_000;

let storage = storageCache.get(participant.name);
Expand All @@ -49,15 +49,19 @@ export function makeStorageTask(
);
const uploadMs = performance.now() - uploadStart;

// Download timing — request raw bytes so we measure a full object fetch
const downloadStart = performance.now();
await step('download', () =>
withTimeout(storage!.download(key, { as: 'bytes' }), timeout, 'Download timed out'),
);
const downloadMs = performance.now() - downloadStart;

// Throughput in Mbps (download-side)
const throughputMbps = (fileSizeBytes * 8) / (downloadMs / 1000) / 1_000_000;
// Download timing — request raw bytes so we measure a full object fetch.
// Throughput (Mbps) is a rate, not a duration, so it can't be inferred
// from the step's latency; measure it inside the `download` step so it
// lands on that step's data (platform step_data_json).
let downloadMs = 0;
let throughputMbps = 0;
await step('download', async () => {
const downloadStart = performance.now();
await withTimeout(storage!.download(key, { as: 'bytes' }), timeout, 'Download timed out');
downloadMs = performance.now() - downloadStart;
throughputMbps = (fileSizeBytes * 8) / (downloadMs / 1000) / 1_000_000;
measure({ throughputMbps });
});

// Cleanup: best-effort delete; failures are warned but don't fail the task.
await step(
Expand Down
Loading