Skip to content

docs(benchmarks): correct stale runBenchmark wording in .bench.ts headers - #260

Closed
devin-ai-integration[bot] wants to merge 1 commit into
masterfrom
devin/1785438750-bench-docstring-cleanup
Closed

docs(benchmarks): correct stale runBenchmark wording in .bench.ts headers#260
devin-ai-integration[bot] wants to merge 1 commit into
masterfrom
devin/1785438750-bench-docstring-cleanup

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Comments only. After the @benchsdk/client / @benchsdk/runner split, some header docstrings still described the old self-running model ("built on @benchsdk/runner's runBenchmark", "orchestration is owned by ... runBenchmark"). runBenchmark is now internal to the runner and entrypoints are declarative (export const config + export const task, executed via bench run <file>), so the wording is updated to say that.

Files whose comments changed:

  • benchmarks/ai-gateway/ai-gateway.bench.ts
  • benchmarks/sandbox/dax.bench.ts
  • benchmarks/storage/snapshot-fork.bench.ts
  • benchmarks/browser/browser-task.ts
  • benchmarks/storage/storage-task.ts
  • benchmarks/storage/snapshot-fork-task.ts (the three *-task.ts files just drop the internal runBenchmark name, keeping "orchestration is owned by @benchsdk/runner")

No code, signatures, exports, config values, files, or structure changed; benchmarks/scale/** untouched. pnpm typecheck passes.

 benchmarks/ai-gateway/ai-gateway.bench.ts | 15 ++++++++-------
 benchmarks/browser/browser-task.ts        |  3 +--
 benchmarks/sandbox/dax.bench.ts           | 11 ++++++-----
 benchmarks/storage/snapshot-fork-task.ts  |  4 ++--
 benchmarks/storage/snapshot-fork.bench.ts |  4 ++--
 benchmarks/storage/storage-task.ts        |  3 +--
 6 files changed, 20 insertions(+), 20 deletions(-)

Left unchanged (historical context, not the old run model — flagging for a human): references to the removed run.ts in benchmarks/storage/*.bench.ts, benchmarks/ai-gateway/ai-gateway.bench.ts, and benchmarks/src/merge-results.ts.

Link to Devin session: https://app.devin.ai/sessions/e0be51dd272f40d5997335584c1270b3
Requested by: @HeyGarrison


Open in Devin Review

…ders

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@HeyGarrison HeyGarrison self-assigned this Jul 30, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@open-cla

open-cla Bot commented Jul 30, 2026

Copy link
Copy Markdown

Contributor License Agreement

All contributors are covered by a CLA.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

Superseded — rolled into the workload-inlining PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant