docs(benchmarks): correct stale runBenchmark wording in .bench.ts headers - #260
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
docs(benchmarks): correct stale runBenchmark wording in .bench.ts headers#260devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…ders Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor License AgreementAll contributors are covered by a CLA. |
Contributor
Author
|
Superseded — rolled into the workload-inlining PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comments only. After the
@benchsdk/client/@benchsdk/runnersplit, some header docstrings still described the old self-running model ("built on @benchsdk/runner's runBenchmark", "orchestration is owned by ... runBenchmark").runBenchmarkis now internal to the runner and entrypoints are declarative (export const config+export const task, executed viabench run <file>), so the wording is updated to say that.Files whose comments changed:
benchmarks/ai-gateway/ai-gateway.bench.tsbenchmarks/sandbox/dax.bench.tsbenchmarks/storage/snapshot-fork.bench.tsbenchmarks/browser/browser-task.tsbenchmarks/storage/storage-task.tsbenchmarks/storage/snapshot-fork-task.ts(the three*-task.tsfiles just drop the internalrunBenchmarkname, keeping "orchestration is owned by @benchsdk/runner")No code, signatures, exports, config values, files, or structure changed;
benchmarks/scale/**untouched.pnpm typecheckpasses.Left unchanged (historical context, not the old run model — flagging for a human): references to the removed
run.tsinbenchmarks/storage/*.bench.ts,benchmarks/ai-gateway/ai-gateway.bench.ts, andbenchmarks/src/merge-results.ts.Link to Devin session: https://app.devin.ai/sessions/e0be51dd272f40d5997335584c1270b3
Requested by: @HeyGarrison