refactor(benchmarks): collapse the 3 sandbox TTI benches into one tti.bench.ts - #262
Merged
Conversation
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor License AgreementAll contributors are covered by a CLA. |
Base automatically changed from
devin/1785441088-bench-inline-workloads
to
master
July 30, 2026 20:13
…r --slug override Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
devin-ai-integration
Bot
force-pushed
the
devin/1785442068-tti-one-file
branch
from
July 30, 2026 20:15
faa6b0c to
8df6b31
Compare
…ug/--name from CI Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Storage Benchmark Results1MB Files
View full run · SVGs available as build artifacts |
Contributor
Snapshot/Fork Benchmark Resultssmall dataset
|
Contributor
Browser Benchmark Results
View full run · SVG available as build artifact |
Contributor
Sandbox Benchmark ResultsSequential
Staggered
Burst
View full run · SVGs available as build artifacts |
Contributor
Browser Throughput Benchmark Results
View full run · SVG available as build artifact |
Contributor
Sandbox Dax Benchmark Results
|
Contributor
AI Gateway Benchmark Results
View full run · SVG available as a build artifact |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sequential/staggered/burstwere three entrypoints around one sharedttiTask, differing only in{concurrency, staggerDelayMs}— knobs the framework already owns. They're now onebenchmarks/sandbox/tti.bench.tswith the workload inline and no mode table: the file declares the sequential default, and the launch shape comes entirely from CLI flags.The legacy results dir and
modetag are derived from the knobs the run actually used, so no shape is declared twice:Slugs and
results/dir names are carried over verbatim (including burst's legacy'concurrent'label), so the platform and the SVG/README pipeline see no rename.Deleted:
sequential.bench.ts,staggered.bench.ts,burst.bench.ts,tti-task.ts.package.jsonscripts keep their names (bench:burstetc.);sandbox-tti-benchmarks.ymlnow builds the three arg lists in one place.--slug/--namein@benchsdk/runnerThis layout needs a benchmark file to stop hardcoding which platform benchmark it reports to:
--slugis validated against/^[a-z0-9][a-z0-9-]*$/; both flags are covered by tests, changeset included.Note (not changed here)
Each provider still gets its own platform run because the workflow uses a
matrix.providerwith--provider <one>; the runner itself will run all participants in a single run. Consolidating that is a CI tradeoff (one provider's quota failure takes down the whole run, and you lose per-provider secret scoping), so it's left alone deliberately.pnpm typecheckclean; runner suite 56 passing.Link to Devin session: https://app.devin.ai/sessions/e0be51dd272f40d5997335584c1270b3
Requested by: @HeyGarrison