-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hazelcast-cpp-client: add version 5.1.0 #15018
Conversation
This comment has been minimized.
This comment has been minimized.
00177dd
to
f1d3747
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
f1d3747
to
12b2fb0
Compare
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 12b2fb0hazelcast-cpp-client/5.1.0
|
12b2fb0
to
ed9dc94
Compare
Conan v1 pipelineAll green in build 5 (
Conan v2 pipeline (informative, not required for merge)Failure in build 4 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Hooks produced the following warnings for commit ed9dc94hazelcast-cpp-client/4.1.0
hazelcast-cpp-client/5.1.0
|
Guys can someone review this PR. It passes all the checks. |
Can you please review and merge @uilianries ? We like to use it in projects using Conan. |
*/ | ||
class HAZELCAST_API ClientMessage | ||
{ | ||
+ template<typename T> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should contribute this back upstream to the project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean previous versions at conan or the hazelcast/hazelcast-cpp-client repo ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To hazelcast/hazelcast-cpp-client repo :)
You can see the current status prince-chrismc/conan-center-index-pending-review#1 The bottom chart shows the estimated time are is almost 2 weeks. Holidays + backend bugs slowed us down. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Specify library name and version: hazelcast-cpp-client/5.1.0