patch packages affected by missing run_exports from petsc, fenics-libdolfinx rattler-build bug #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
beckermr
previously requested changes
Mar 4, 2025
|
Sorry for being unclear. This doesn't patch run_exports. It patches the dependencies in downstream packages that are missing because of the bad run_exports. |
minrk
changed the title
minrk
changed the title
beckermr
requested changes
Mar 5, 2025
beckermr
approved these changes
Mar 5, 2025
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug in rattler-build means that any package with multiple run_exports in a single list will only produce packages with the last item in
run_exports: prefix-dev/rattler-build#1468Probably not too many packages affected, as most have a single run_export. But petsc and fenics-libdolfinx have multiple run_exports fields, which have been producing downstream packages with inadequate pinning. This patches those downstream packages, built with the bad packages in
host. Only packages published in a relatively short window are affected, so this usestimestamp_gtbecause the conditions aren't perfect and would pull in some very old packages that are not affected, but all the matched packages within the time window get correct patches.This is fixed by PRs:
Checklist
pre-commit run -aand ensured all files pass the linting checks.python show_diff.pyand posted the output as part of the PR.diff