-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't skip Intel Mac #38
base: main
Are you sure you want to change the base?
Conversation
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2025.02.23.12.16.18
@oleksandr-pavlyk, I noticed that in #32 you began skipping the I noticed because we depend on mkl-service in conda-forge/pytensor-suite-feedstock#137, but we are currently missing a build for the combination osx / python3.13. |
@conda-forge-admin, please rerender |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13483703604. Examine the logs at this URL for more detail. |
…nda-forge-pinning 2025.02.23.12.16.18
Converted to draft since I still need to bump the build number |
Linux builds seem to be failing due to conda/conda-build#5626 |
@conda-forge-admin, please rerender |
Looks like the LIEF issue is being actively fixed in conda-forge/conda-forge-repodata-patches-feedstock#966, so hopefully it will just start working again. |
@napetrov I think it makes sense to build mkl-service for OSX to support older versions of MKL that were built for osx |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13483940265. Examine the logs at this URL for more detail. |
The repodata patch hasn't kicked in yet, but at least the OSX builds are passing. Regardless, we could still merge this despite the failing Linux builds because this is just a transient error, and we already have those failed Linux builds. |
@oleksandr-pavlyk, does the current version support osx, or do you suggest only rebuilding previous versions? |
BLAS is not yet available. <conda-forge/mkl-service-feedstock#38>
Once the following has been merged so that BLAS is available: <conda-forge/mkl-service-feedstock#38>
Point was that MKL dropped OSX support from 2024.0 release, so enabling mkl-service back will not help enable new MKL version on OSX. So by enabling this back we would enable just older version on mac. The only problem is that we are not testing this combination of new mkl-service with older MKL versions. It should work, but there is chance that it would break at some point. But it's ok to enable this |
@oleksandr-pavlyk, this is leading to problems, e.g. conda-forge/nutpie-feedstock#58. Would it be possible to merge this while we look for an alternative to MKL on OSX? Or at least could we rebuild a <2024.0 release to support Python 3.13? |
yes in short. @oleksandr-pavlyk can merge this one or just give me maintainer rights on fedstock and i would merge it - #39 |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)