Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't skip Intel Mac #38

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Feb 23, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@maresb
Copy link
Contributor Author

maresb commented Feb 23, 2025

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@maresb
Copy link
Contributor Author

maresb commented Feb 23, 2025

@oleksandr-pavlyk, I noticed that in #32 you began skipping the osx platform. But does mlk-service make sense on Intel-based Macs?

I noticed because we depend on mkl-service in conda-forge/pytensor-suite-feedstock#137, but we are currently missing a build for the combination osx / python3.13.

@maresb
Copy link
Contributor Author

maresb commented Feb 23, 2025

@conda-forge-admin, please rerender

@maresb
Copy link
Contributor Author

maresb commented Feb 23, 2025

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13483703604. Examine the logs at this URL for more detail.

@maresb maresb marked this pull request as draft February 23, 2025 14:03
@maresb
Copy link
Contributor Author

maresb commented Feb 23, 2025

Converted to draft since I still need to bump the build number

@maresb
Copy link
Contributor Author

maresb commented Feb 23, 2025

Linux builds seem to be failing due to conda/conda-build#5626

@maresb
Copy link
Contributor Author

maresb commented Feb 23, 2025

@conda-forge-admin, please rerender

@maresb
Copy link
Contributor Author

maresb commented Feb 23, 2025

Looks like the LIEF issue is being actively fixed in conda-forge/conda-forge-repodata-patches-feedstock#966, so hopefully it will just start working again.

@oleksandr-pavlyk
Copy link
Contributor

@napetrov I think it makes sense to build mkl-service for OSX to support older versions of MKL that were built for osx

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13483940265. Examine the logs at this URL for more detail.

@maresb
Copy link
Contributor Author

maresb commented Feb 23, 2025

The repodata patch hasn't kicked in yet, but at least the OSX builds are passing.

Regardless, we could still merge this despite the failing Linux builds because this is just a transient error, and we already have those failed Linux builds.

@maresb
Copy link
Contributor Author

maresb commented Feb 23, 2025

@oleksandr-pavlyk, does the current version support osx, or do you suggest only rebuilding previous versions?

@maresb maresb marked this pull request as ready for review February 23, 2025 14:31
@maresb maresb closed this Feb 23, 2025
@maresb maresb reopened this Feb 23, 2025
@maresb maresb closed this Feb 23, 2025
@maresb maresb reopened this Feb 23, 2025
maresb added a commit to regro-cf-autotick-bot/pytensor-suite-feedstock that referenced this pull request Feb 23, 2025
maresb added a commit to maresb/pytensor-suite-feedstock that referenced this pull request Feb 23, 2025
Once the following has been merged so that BLAS is available:
<conda-forge/mkl-service-feedstock#38>
@napetrov
Copy link

@oleksandr-pavlyk, does the current version support osx, or do you suggest only rebuilding previous versions?

Point was that MKL dropped OSX support from 2024.0 release, so enabling mkl-service back will not help enable new MKL version on OSX. So by enabling this back we would enable just older version on mac.

The only problem is that we are not testing this combination of new mkl-service with older MKL versions. It should work, but there is chance that it would break at some point. But it's ok to enable this

@maresb
Copy link
Contributor Author

maresb commented Mar 7, 2025

@oleksandr-pavlyk, this is leading to problems, e.g. conda-forge/nutpie-feedstock#58. Would it be possible to merge this while we look for an alternative to MKL on OSX?

Or at least could we rebuild a <2024.0 release to support Python 3.13?

@napetrov
Copy link

napetrov commented Mar 7, 2025

@oleksandr-pavlyk, this is leading to problems, e.g. conda-forge/nutpie-feedstock#58. Would it be possible to merge this while we look for an alternative to MKL on OSX?

Or at least could we rebuild a <2024.0 release to support Python 3.13?

yes in short. @oleksandr-pavlyk can merge this one or just give me maintainer rights on fedstock and i would merge it - #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants