-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tensorflow-probability #56
Conversation
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13159011292. Examine the logs at this URL for more detail. |
…nda-forge-pinning 2025.02.04.19.34.29
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13159706390. Examine the logs at this URL for more detail. |
…nda-forge-pinning 2025.02.04.19.34.29
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13159558716. Examine the logs at this URL for more detail. |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13159720112. Examine the logs at this URL for more detail. |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13159874562. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13159879563. Examine the logs at this URL for more detail. |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13436159965. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13159962243. Examine the logs at this URL for more detail. |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13160118693. Examine the logs at this URL for more detail. |
@jonas-eschle Need to test the previous tensorflow-probability version on 2.18, so let's wait until tf-keras 2.18 is added. |
The error message when you use Tensorflow 2.17.0 with 0.25.0 for people in the future (0.24.0 works fine):
|
So conclusion (I've built the versions and tried it for real in conda): This version depends on tf-keras >=2.18 so this can only be merged when that is merged. For whether the upward bound dependency constraints can be relieved, need to test tensorflow-probability 0.24.0 with TensorFlow 2.18.0, and test JAX 0.5.x on tensorflow-probability 0.24.0 and 0.25.0. Both need to wait for respective feedstocks. |
Agree. We just don't know about JAX, but I don't think it's a disadvantage, really. If you wat to upgrade, why not also upgrade JAX? And if there is a good reason not to, i.e. because JAX had breaking changes, chances are, that exactly these will also break TFP. So yes, agree.
Agree. I would suggest not to make these "blocking" items for now: as soon as TF-Keras is out, we should release this. Preferrably with the restrictions in place (the jump to 0.5 could indicate something larger, so maybe we make one at a time/resubmit an increased boundary/no boundary if we're confident. Always ugly if code breaks at runtime error and you need to figure out that this is due to a version mismatch, i.e. too new JAX version for example). Much harder than finding a way around the dependency. |
"conda-forge JAX maintainer" sounds nice, I'll try. |
And yeah, we should merge immediately when tf-keras is merged. |
It seems that something crazy is going on to make jaxlib (https://github.com/conda-forge/jaxlib-feedstock/pull/294/files) work and I don't think I'm really ready for this yet. I still don't understand Bazel well enough and the peripheral TensorFlow packages (mostly tensorflow-datasets, array-record, tensorflow-text, etc.) were supposed to be an opportunity to get deeper into this before being introduced into the more important packages. |
Same here, my knowledge of Bazel is very limited. But it seems as if it works, so let's see! (btw, if you wanna just test, you can use the pip version, right?) |
You are right, I just made the same assumptions as TensorFlow where you need to use a Conda build to verify CUDA, when the topic here isn't CUDA. |
@jonas-eschle Apparently, the case is that JAX 0.5.0 (pip) with TensorFlow Probability 0.25.0 (pip) does not introduce substantial backwards incompatible changes in its interface.
|
@jonas-eschle The combination of TensorFlow 2.18.0 (conda-forge) and tf-keras 2.18.0 (pip) with TensorFlow Probability 0.24.0 (the older version) did not present any issues.
|
@conda-forge-admin, please rerender |
Yes, however, this is just testing a tiny subset of the functionality. If we want to assure that things work, we would need to run at least the whole test suite. And ideally on different machines, i.e. Linux, OSX, Windows.... Also, just because the old one did not break does not mean that newer version won't break. So I would still say for JAX, if they do a major upgrade to 0.5, it's save to not yet release it. For TF, I am less sure what (and if) to constrain it. |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13434217828. Examine the logs at this URL for more detail. |
I will reverting the constraints for JAX. |
True. But this isn't our choice, right? TFP simply won't work wit a lower version, it's in the code
Actually, good argument. Pip has the same problem. Why be more constraint here. I am fine with removing the upper constraint for JAX as well, the argument convinced me now |
The argument is not with the past, but the future (combination of TensorFlow 2.19.x potentially with TensorFlow Probability 0.25.0 when they decide to skip a matched release again).
Sure, I will remove the upper bound constraints again. An older TensorFlow version then 2.18.0 is blocked, obviously, and key capabilities in JAX breaks with TensorFlow Probability 0.25.0 at around version 0.4.24 or 0.4.23 (I have tested so). So decreasing the lower limits is risky, and should be kept, whether or not |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13435906324. Examine the logs at this URL for more detail. |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13436174385. Examine the logs at this URL for more detail. |
@jonas-eschle And the builds succeed... I think if there is an issue with the upper bounds somehow, we can limit it when there is an issue, since |
Very well, I may misunderstood, but we agree.
It's not that easy, and the argument also works the other way around: you can relax it once we know it works. I am saying that it's not that easy, because how do you know it broke because of a mismatched version? A user may randomly bumps into it. But that's not a version error. That's a random error. And the user tracks it down, may first thinks it's him. If he is a power user, he can track it down and, fair enough, report it maybe in TFP (or here). But there are a lot of ifs. Most notably, if will cause hard to understand bugs for users. But we agree, LGTM! Many thanks for this contribution! |
Yeah, learned a lot of things in the progress. Thanks for your continued patience. @jonas-eschle |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Closes #53
Closes #54
Closes #55