Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.New system task that enables workflows to execute SQL queries against configured database instances. Includes:
SqliteIndexDAO.searchWorkflows() and searchTasks() returned full JSON blobs instead of IDs, breaking the v2 search API contract. Fixed SqliteIndexQueryBuilder to accept a selectColumn parameter so v2 search
selects workflow_id/task_id only. Added 6 test cases covering basic search, pagination with ordering, and null sort handling.
Alternatives considered
JDBC Task: Considered implementing as a pure worker (external process) rather than a system task. A system task was chosen because it runs on the server with managed connection pools — avoiding the need for
every worker deployment to carry database credentials and connection config.
SQLite search-v2: Considered adding a separate query method to SqliteIndexDAO instead of modifying the query builder. Chose to extend SqliteIndexQueryBuilder.getQuery() with a selectColumn overload to keep
the fix minimal and co-located with the existing query construction logic.
Docs URL format: Considered keeping use_directory_urls: true (directory-style URLs like /java-sdk/). Reverted to false to avoid breaking all existing external links pointing to .html URLs from the v3.22.1
site.