Regenerate USM commands to swap command name and alias for register/deregister and create/delete - #3461
Conversation
There was a problem hiding this comment.
Pull request overview
This PR regenerates the Confluent Cloud USM Kafka/Connect cluster commands so register/deregister are the primary command names again, while keeping create/delete as aliases to avoid breaking existing workflows.
Changes:
- Swap Cobra
Use/Aliasessoregister/deregisterare primary for USM Kafka/Connect cluster commands, withcreate/deleteretained as aliases. - Update integration tests and golden fixtures (help text, autocomplete, and delete confirmation/output) to reflect the regenerated command surface.
- Regenerate USM Kafka cluster output ordering (table columns and JSON/YAML key order) as part of the codegen output.
Reviewed changes
Copilot reviewed 24 out of 34 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| test/usm_kafka_cluster_test.go | Updates integration tests to invoke register/deregister and refreshes generator header. |
| test/usm_connect_cluster_test.go | Updates integration tests to invoke register/deregister and refreshes generator header. |
| test/test-server/usm_kafka_cluster_handler.go | Refreshes generator header for the test server handler. |
| test/test-server/usm_connect_cluster_handler.go | Refreshes generator header for the test server handler. |
| test/fixtures/output/usm/kafka-cluster/register-help.golden | Updates help output to show register as the primary command and create as alias. |
| test/fixtures/output/usm/kafka-cluster/deregister-help.golden | Updates help output to show deregister as the primary command and delete as alias. |
| test/fixtures/output/usm/kafka-cluster/help.golden | Updates subcommand listing to show register/deregister as available commands. |
| test/fixtures/output/usm/kafka-cluster/create/create.golden | Refreshes create/register output fixture (includes field/row ordering changes). |
| test/fixtures/output/usm/kafka-cluster/delete/delete.golden | Updates delete output wording to match deregister success messaging. |
| test/fixtures/output/usm/kafka-cluster/delete/delete-no-force.golden | Updates confirmation prompt/success output wording for deregister. |
| test/fixtures/output/usm/kafka-cluster/delete/delete-multiple.golden | Updates multi-delete confirmation prompt/success output wording for deregister. |
| test/fixtures/output/usm/kafka-cluster/list/list.golden | Refreshes list table column ordering to match regenerated output ordering. |
| test/fixtures/output/usm/kafka-cluster/list/list-json.golden | Refreshes JSON fixture ordering to match regenerated output ordering. |
| test/fixtures/output/usm/kafka-cluster/list/list-yaml.golden | Refreshes YAML fixture ordering to match regenerated output ordering. |
| test/fixtures/output/usm/kafka-cluster/describe/describe.golden | Refreshes describe table row ordering to match regenerated output ordering. |
| test/fixtures/output/usm/kafka-cluster/describe/describe-json.golden | Refreshes describe JSON fixture ordering to match regenerated output ordering. |
| test/fixtures/output/usm/kafka-cluster/describe/describe-yaml.golden | Refreshes describe YAML fixture ordering to match regenerated output ordering. |
| test/fixtures/output/usm/connect-cluster/register-help.golden | Updates help output to show register as the primary command and create as alias. |
| test/fixtures/output/usm/connect-cluster/deregister-help.golden | Updates help output to show deregister as the primary command and delete as alias. |
| test/fixtures/output/usm/connect-cluster/help.golden | Updates subcommand listing to show register/deregister as available commands. |
| test/fixtures/output/usm/connect-cluster/delete/delete.golden | Updates delete output wording to match deregister success messaging. |
| test/fixtures/output/usm/connect-cluster/delete/delete-no-force.golden | Updates confirmation prompt/success output wording for deregister. |
| test/fixtures/output/usm/connect-cluster/delete/delete-multiple.golden | Updates multi-delete confirmation prompt/success output wording for deregister. |
| internal/usm/command_kafka_cluster.go | Regenerates Kafka cluster command wiring and output struct ordering. |
| internal/usm/command_kafka_cluster_list.go | Regenerates list output population consistent with the updated output struct. |
| internal/usm/command_kafka_cluster_describe.go | Refreshes generator header for describe command. |
| internal/usm/command_kafka_cluster_create.go | Makes register primary and create an alias for Kafka cluster creation. |
| internal/usm/command_kafka_cluster_delete.go | Makes deregister primary and delete an alias for Kafka cluster deletion. |
| internal/usm/command_connect_cluster.go | Regenerates Connect cluster command wiring and output struct definition. |
| internal/usm/command_connect_cluster_list.go | Refreshes generator header for list command. |
| internal/usm/command_connect_cluster_describe.go | Refreshes generator header for describe command. |
| internal/usm/command_connect_cluster_create.go | Makes register primary and create an alias for Connect cluster creation. |
| internal/usm/command_connect_cluster_delete.go | Makes deregister primary and delete an alias for Connect cluster deletion. |
| .cli-generation-checksum | Updates the codegen checksum to match regenerated sources/fixtures. |
Files not reviewed (10)
- internal/usm/command_connect_cluster.go: Generated file
- internal/usm/command_connect_cluster_create.go: Generated file
- internal/usm/command_connect_cluster_delete.go: Generated file
- internal/usm/command_connect_cluster_describe.go: Generated file
- internal/usm/command_connect_cluster_list.go: Generated file
- internal/usm/command_kafka_cluster.go: Generated file
- internal/usm/command_kafka_cluster_create.go: Generated file
- internal/usm/command_kafka_cluster_delete.go: Generated file
- internal/usm/command_kafka_cluster_describe.go: Generated file
- internal/usm/command_kafka_cluster_list.go: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
a3b3dd1
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
|




Release Notes
Breaking Changes
New Features
Bug Fixes
confluent usm [connect-cluster | kafka-cluster] [register | deregister]commands so that[register | deregister]are the default operations and[create | delete]are the aliasesChecklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
The previous regeneration of the cloud USM commands renamed
confluent usm [kafka | connect] [register | deregister]toconfluent usm [kafka | connect] [create | delete]and addedregister&deregisteras aliases. This PR reverses the order; setting the primary names back toregisterandderegisterbut maintainingcreateanddeleteas aliases to prevent breaking changes.Blast Radius
Minimal. This is simply changing what is the primary command name and what is the alias; both will continue to function.
References
Test & Review
Existing integration tests pass.
Manually tested
create/deleteandregister/deregisterfor both Kafka and Connect USM clusters following similar cases as the previous testing: https://docs.google.com/document/d/1ao0caPEUF4w8r8MhIVM-PKfaJkSPeJifr88wuZWWSUg/edit?usp=sharing