Add Confluent-Client-Version header to requests to SR, JS client #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds a Confluent-Client-Version header to all Schema Registry requests to identify the client library and version being used.
- Imports the version from package.json
- Sets the
Confluent-Client-Versionheader with formatjavascript/{version}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import { RestError } from './rest-error'; | ||
| import axiosRetry from "axios-retry"; | ||
| import { fullJitter, isRetriable, isSuccess } from './retry-helper'; | ||
| import { version } from './package.json'; |
There was a problem hiding this comment.
Importing directly from package.json may fail at runtime depending on the TypeScript configuration. Consider using require() or ensure resolveJsonModule is enabled in tsconfig.json. Alternatively, use a dynamically imported version constant to avoid potential compilation issues.
Suggested change
| import { version } from './package.json'; | |
| const { version } = require('./package.json'); |
fangnx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please prefix all TypeScript pull-requests with
[Typescript]What
Checklist
References
JIRA: https://confluentinc.atlassian.net/browse/DGS-22770
Test & Review
Open questions / Follow-ups