Skip to content

Update BufferedRecords.java #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update BufferedRecords.java #1488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions src/main/java/io/confluent/connect/jdbc/sink/BufferedRecords.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,15 +195,30 @@ public List<SinkRecord> flush() throws SQLException {
}

private void executeUpdates() throws SQLException {
int[] batchStatus = updatePreparedStatement.executeBatch();
for (int updateCount : batchStatus) {
if (updateCount == Statement.EXECUTE_FAILED) {
throw new BatchUpdateException(
"Execution failed for part of the batch update", batchStatus);
try {
updatePreparedStatement.executeBatch();
} catch (BatchUpdateException bue) {
SQLException nextException = bue.getNextException();
boolean hasNonDuplicateErrors = false;

while (nextException != null) {
if (nextException.getErrorCode() == 1 || nextException.getMessage().contains("ORA-00001")) {
log.warn("Skipping duplicate record due to ORA-00001: {}", nextException.getMessage());
} else {
hasNonDuplicateErrors = true;
log.error("SQL Error during batch update: {}", nextException.getMessage(), nextException);
}
nextException = nextException.getNextException();
}

// Only throw the original exception if it contains non-duplicate errors
if (hasNonDuplicateErrors) {
throw bue;
}
}
}
}


private void executeDeletes() throws SQLException {
if (nonNull(deletePreparedStatement)) {
int[] batchStatus = deletePreparedStatement.executeBatch();
Expand Down