Skip to content

sem trigger #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

sem trigger #1503

wants to merge 4 commits into from

Conversation

Kalla-Shubham
Copy link
Member

Problem

Developer want to test his changes in the connector against KDP test cases. This makes a good pr gating option to ensure nothing is breaking end to end from a particular dev change.

Solution

A separate task has been created which gets trigger from sem trigger to run the mapped KDP test cases for the connector changes.

Does this solution apply anywhere else?
  • yes
  • no
If yes, where?

Test Strategy

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

Release Plan

@Copilot Copilot AI review requested due to automatic review settings April 25, 2025 07:57
@Kalla-Shubham Kalla-Shubham requested a review from a team as a code owner April 25, 2025 07:57
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new CI block to trigger the connector jar tests via a sem-trigger command when a pull request is raised, ensuring end‐to‐end validation of connector changes.

  • Added a new CI gating block ("Connector Jar Build CI Gating") in the semaphore configuration.
  • Incorporated a sem-trigger command to invoke the Connect Jar KDP Test Task using specified parameters.
Comments suppressed due to low confidence (1)

.semaphore/semaphore.yml:92

  • [nitpick] The trailing semicolon in the sem-trigger command may be unnecessary and could affect the shell command execution; please verify if it is required.
              -w; \

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

2 similar comments
@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (81.90% Estimated after merge)
  • Duplications No duplication information (2.90% Estimated after merge)

Project ID: kafka-connect-jdbc

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant