-
Notifications
You must be signed in to change notification settings - Fork 991
Add Connector Name and Task ID in the Table Monitor Thread Name #1509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KGaneshDatta
wants to merge
18
commits into
10.8.x
Choose a base branch
from
jdbc_thread_id_patch1
base: 10.8.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CC-32766 - Exposing the threadIds of new threads created by the JDBC Connector apart from the task thread.
There are few other threads which are created apart from the task thread by the connector in order to monitor or perform another actions. Tracking these threads would be difficult as it cannot be identified of which connector they belong to.
In order to track these threads, it is required to have threadIds for these threads such that it would be easier to monitor them in case of any thread leaks/high resource consumption.
Solution
Add the connector name and the task Id for the newly created threads if any in the JDBC Connectors (both Source & Sink).
Does this solution apply anywhere else?
If yes, where?
Test Strategy
Testing done:
Release Plan